Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-9703 project_ids and organization_scoped to oauth client #1148

Merged

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Nov 20, 2023

Description

Add project_ids and organization scoped to oauth client data source.

Needs to be merged after: #1144

Remember to:

Testing plan

Run the tests without skip beta flag locally.
CI test passes

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

Documentation Output

Screenshot 2023-11-20 at 11 35 21 AM

@Netra2104 Netra2104 changed the title Netra2104/tf 9703 project oauth client data source changes TF-9703 project_ids and organization_scoped to oauth client Nov 20, 2023
@netramali netramali marked this pull request as ready for review March 7, 2024 15:21
@netramali netramali requested a review from a team as a code owner March 7, 2024 15:21
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ 👇

internal/provider/data_source_oauth_client.go Show resolved Hide resolved
@netramali netramali requested a review from brandonc April 15, 2024 16:11
@jbonhag jbonhag requested a review from a team April 17, 2024 16:47
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@netramali netramali requested review from brandonc and removed request for brandonc April 19, 2024 15:11
@laurenolivia laurenolivia merged commit e8bbfd2 into main Apr 22, 2024
9 checks passed
@laurenolivia laurenolivia deleted the Netra2104/TF-9703-project-oauth-client-data-source-changes branch April 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants