update error message regarding the option force_delete, which can be … #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
reviewed
Mar 5, 2024
brandonc
approved these changes
Mar 7, 2024
sebasslash
reviewed
Mar 8, 2024
| @@ -1005,7 +1005,7 @@ func resourceTFEWorkspaceImporter(ctx context.Context, d *schema.ResourceData, m | |||
| func errWorkspaceSafeDeleteWithPermission(workspaceID string, err error) error { | |||
| if err != nil { | |||
| if strings.HasPrefix(err.Error(), "conflict") { | |||
| return fmt.Errorf("error deleting workspace %s: %w\nTo delete this workspace without destroying the managed resources, add force_delete = true to the resource config", workspaceID, err) | |||
| return fmt.Errorf("error deleting workspace %s: %w\nTo delete this workspace, that either has managed resources or has a state version that still being processed, add force_delete = true to the resource config", workspaceID, err) | |||
There was a problem hiding this comment.
Minor grammar fix: or has a state version that is still being processed
…used also for the case when a workspace has no resources but the state version is still being processed
uturunku1
force-pushed
the
update-error-msg
branch
from
dbd32b7
to
85e1fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…used also for the case when a workspace has no resources but the state version is still being processed
Description
The force-delete option is not only option for when a workspace has managed resources, but also when a workspaces has no resources but the state version is in the middle of being processed.
Slack conversation that can provide a bit more information about this: https://hashicorp.slack.com/archives/C01BR9FR8KZ/p1709331588604969
Related change: hashicorp/go-tfe#864
Remember to:
Testing plan
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.