Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-14896] Add rule to ignore linter #1333

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Apr 23, 2024

Description

This PR adds a rule to prevent CI linters from blocking a merge where WorkspaceRunTask.Stage is used. The Stage field was only recently deprecated.

See how it is currently used here.

Remember to:

Testing plan

  1. Describe how to replicate
  2. the conditions
  3. under which your code performs its purpose,
  4. including example Terraform configs where necessary.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

@laurenolivia laurenolivia requested a review from a team as a code owner April 23, 2024 20:47
@laurenolivia laurenolivia force-pushed the laurenolivia/fix-deprecated-stage-field branch from a0cfecb to 8a86a3a Compare April 23, 2024 20:53
@laurenolivia laurenolivia changed the title Add rule to ignore linter [TF-14896] Add rule to ignore linter Apr 23, 2024
@laurenolivia laurenolivia merged commit c325dcb into main Apr 23, 2024
9 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/fix-deprecated-stage-field branch April 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants