[#TF-15257] add manage-agent-pools to team organization access #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlanctot
force-pushed
the
el/add_manage_agent_pools_to_org_access
branch
from
a55118c
to
3a0b808
Compare
emlanctot
force-pushed
the
el/add_manage_agent_pools_to_org_access
branch
from
3a0b808
to
48c8b7e
Compare
emlanctot
changed the title
CHANGELOG.md
Outdated
Comment on lines
3
to
5
| ## v0.56.0 | ||
|
|
||
| FEATURES: | ||
| * `r/tfe_team`: Add attribute `manage_agent_pools` to `organization_access` on `tfe_team` by @emlanctot [#1358](https://github.com/hashicorp/terraform-provider-tfe/pull/1358) | ||
|
|
There was a problem hiding this comment.
I believe this needs to be moved in the unreleased section, as v0.56.0 looks like the latest release!
website/docs/r/team.html.markdown
Outdated
| @@ -58,6 +58,7 @@ The `organization_access` block supports: | |||
| * `manage_teams` - (Optional) Allow members to create, update, and delete teams. | |||
| * `manage_organization_access` - (Optional) Allow members to update the organization access settings of teams. | |||
| * `access_secret_teams` - (Optional) Allow members access to secret teams up to the level of permissions granted by their team permissions setting. | |||
| * `manage_secret_teams` - (Optional) Allows members to create, edit, and delete agent pools within their organization. | |||
There was a problem hiding this comment.
Suggestion: I believe that manage_agent_pools is what we're looking for here 😊 :
Suggested change
| * `manage_secret_teams` - (Optional) Allows members to create, edit, and delete agent pools within their organization. | |
| * `manage_agent_pools` - (Optional) Allows members to create, edit, and delete agent pools within their organization. |
emlanctot
force-pushed
the
el/add_manage_agent_pools_to_org_access
branch
from
a6b4733
to
ad38813
Compare
juliannatetreault
approved these changes
Jun 17, 2024
nickmcdonnough
approved these changes
Jun 17, 2024
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support that will allow the manage_agent_pools organization access setting to be set on teams via the provider.
Remember to:
Testing plan
manage_agent_poolsshould default to false for new teams.manage_agent_poolsis omitted, they should default to false.manage_agent_poolsshould be able to be set or unset via the provider.External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.