Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workspace remote state consumer #292

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

omarismail
Copy link
Contributor

@omarismail omarismail commented Apr 16, 2021

Description

This adds global_remote_state and remote_state_consumer_ids to workspaces. Read more about remote state sharing here

External Links

Output from acceptance tests

$ make testacc

@omarismail omarismail changed the title Spike controlled remote state Add Workspace remote state consumer Apr 16, 2021
@omarismail omarismail requested a review from a team April 16, 2021 16:42
@omarismail omarismail marked this pull request as ready for review April 20, 2021 22:25
go.mod Show resolved Hide resolved
Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, just a few more bits to add and polish up.

tfe/resource_tfe_workspace.go Outdated Show resolved Hide resolved
website/docs/r/workspace.html.markdown Show resolved Hide resolved
tfe/resource_tfe_workspace_test.go Show resolved Hide resolved
tfe/data_source_workspace.go Show resolved Hide resolved
website/docs/r/workspace.html.markdown Show resolved Hide resolved
Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer! I'll pull down this build and give it a spin now while we wrestle with tests and polish up the last little bits.

github.com/hashicorp/go-retryablehttp v0.6.8 // indirect
github.com/hashicorp/go-slug v0.7.0 // indirect
github.com/hashicorp/go-tfe v0.14.0
github.com/hashicorp/go-version v1.2.1
github.com/hashicorp/hcl v0.0.0-20180404174102-ef8a98b0bbce
github.com/hashicorp/terraform-plugin-sdk/v2 v2.3.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Did you intend for an SDK bump in these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah excellent!

website/docs/d/workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/d/workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/workspace.html.markdown Outdated Show resolved Hide resolved
@chrisarcand chrisarcand force-pushed the spike-controlled-remote-state branch from 00ebadb to d452f63 Compare April 28, 2021 03:41
@chrisarcand chrisarcand force-pushed the spike-controlled-remote-state branch from bfd41ad to f84dd98 Compare April 28, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants