Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new org attribute: send_passing_statuses_for_untriggered_speculative_plans #386

Conversation

brandonc
Copy link
Collaborator

Description

New API feature parity

Testing plan

Given the org resource:

resource "tfe_organization" "foo" {
  name                    = "foo"
  email                    = "bcroft@hashicorp.com"
  send_passing_statuses_for_untriggered_speculative_plans = false
}

send_passing_statuses_for_untriggered_speculative_plans is true by default so this resource should change that to false

External links

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-v -run TestAccTFEOrganizationDataSource" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -v -run TestAccTFEOrganizationDataSource -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFEOrganizationDataSource_basic
--- PASS: TestAccTFEOrganizationDataSource_basic (25.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	25.526s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]

@brandonc brandonc requested a review from a team as a code owner October 22, 2021 18:06
@brandonc brandonc force-pushed the brandonc/org_send-passing-statuses-for-untriggered-speculative-plans branch from 4856a92 to 665efeb Compare October 22, 2021 18:06
@brandonc
Copy link
Collaborator Author

Docs Preview

Screen Shot 2021-10-22 at 1 27 22 PM

* `cost_estimation_enabled` - Whether or not the cost estimation feature is enabled for all workspaces in the organization. Defaults to true. In a Terraform Cloud organization which does not have Teams & Governance features, this value is always false and cannot be changed. In Terraform Enterprise, Cost Estimation must also be enabled in Site Administration.
* `owners_team_saml_role_id` - The name of the "owners" team.
* `send_passing_statuses_for_untriggered_speculative_plans` - Whether or not to send VCS status updates for untriggered speculative plans. This can be useful if large numbers of untriggered workspaces are exhausting request limits for connected version control service providers like GitHub. Defaults to true. In Terraform Enterprise, this setting is always true and cannot be changed but is also available in Site Administration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to true.
Isn't this defaulting to false now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@brandonc brandonc force-pushed the brandonc/org_send-passing-statuses-for-untriggered-speculative-plans branch from 8bad009 to 4f07d98 Compare October 29, 2021 20:30
Copy link
Contributor

@omarismail omarismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandonc brandonc merged commit bb20efd into main Nov 12, 2021
@brandonc brandonc deleted the brandonc/org_send-passing-statuses-for-untriggered-speculative-plans branch November 12, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants