Fix/do not use computed #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarismail
approved these changes
Jul 22, 2022
brandonc
approved these changes
Jul 22, 2022
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ENHANCEMENTS: | |||
| * d/agent_pool: Improve efficiency of reading agent pool data when the target organization has more than 20 agent pools ([#508](https://github.com/hashicorp/terraform-provider-tfe/pull/508)) | |||
| * Added warning logs for 404 error responses ([#538](https://github.com/hashicorp/terraform-provider-tfe/pull/538)) | |||
| * r/tfe_workspace: Fix `trigger-prefixes` could not be updated because of the conflict with `trigger-patterns` in some cases - as described in this [GitHub Issue](https://github.com/hashicorp/terraform-provider-tfe/issues/552) ([#564](https://github.com/hashicorp/terraform-provider-tfe/pull/564/)) | |||
There was a problem hiding this comment.
Can you add this to a new Bug Fixes heading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue described in this GitHub issue.
It should prevent sending trigger-patterns and trigger-prefixes in the same request, which is currently causing failures for the Terraform Enterprise with version
v202205-1. The issues is occurring because this version of TFE checks for an invariant thattrigger-patternsandtrigger-prefixesshould NOT be present at the same time. The latest Atlas codebase (and newer versions of TFE) is checking that these values (arrays) are not populated rather for the presence, meaning the issues is not present in newer versions.The above fix is using raw configuration reading, and for that we had to bump up the SDK version to
v2.8.0This PR also addresses some other quirks we were experiencing because the fields
trigger-patternsandtrigger-prefixeswere marked ascomputed. Thecomputedtrait has been removed for these fields and we introduced a more comprehensive test suite.Remember to:
Update the Change Log
Update the Documentation
Testing plan
TFEversionv202205-1or checkout the Atlas codebase with the same git tagtrigger-prefixessettrigger-prefixesandtrigger-patternsExternal links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.