Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Use go 1.18 when building/testing in circle ci #643

Merged
merged 1 commit into from
Oct 4, 2022
Merged

⬆️ Use go 1.18 when building/testing in circle ci #643

merged 1 commit into from
Oct 4, 2022

Conversation

annawinkler
Copy link
Contributor

Description

Other 3rd party libraries are using 1.18 so let's get our build system also using 1.18.

Testing plan

  1. The circle ci tests should still run.

External links

N/A

Output from acceptance tests

N/A

@annawinkler annawinkler requested a review from a team as a code owner October 3, 2022 20:53
@annawinkler annawinkler mentioned this pull request Oct 3, 2022
Merged
laurenolivia
laurenolivia approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annawinkler annawinkler merged commit ebe8e15 into main Oct 4, 2022
@annawinkler annawinkler deleted the aw/circleci-use-go-1.18 branch October 4, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenolivia laurenolivia laurenolivia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annawinkler @laurenolivia