d/workspace_ids: Require exact match when no wildcard #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
force-pushed
the
TF-3556-terraform-provider-tfe-gh-issue-748-tfe-project-invalid-value-for-name-for-simple-project-name-with-in-it
branch
from
6dcf862
to
bb4f587
Compare
laurenolivia
reviewed
Jan 4, 2023
| @@ -56,7 +56,7 @@ func includedByName(names map[string]bool, workspaceName string) bool { | |||
| case len(name) == 0: | |||
| continue | |||
| case !strings.HasPrefix(name, "*") && !strings.HasSuffix(name, "*"): | |||
| if strings.Contains(workspaceName, name) { | |||
| if name == workspaceName { | |||
There was a problem hiding this comment.
👍 Nice catch. Wondering how the behavior of strings.Contains(workspaceName, name) creates a bug, since they both perform a string comparison?
There was a problem hiding this comment.
It's because Contains doesn't match the whole string -- strings.Contains("partial", "art") will return true, but "partial" == "art" is false.
nfagerlund
approved these changes
Jan 4, 2023
|
👍 thanks @nfagerlund. |
brandonc
deleted the
TF-3556-terraform-provider-tfe-gh-issue-748-tfe-project-invalid-value-for-name-for-simple-project-name-with-in-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in the new d/tfe_workspace_ids wildcard logic that performed a substring match even when no wildcards were present
External links
Closes #747
Output from acceptance tests