Only set oauth_token_id and github_app_installation_id if configured
#835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fixes hashicorp#834 Signed-off-by: Samuel Suter <ssuter@twilio.com>
moensch
force-pushed
the
optional-vcs-params-to-null
branch
from
ff5f23a
to
94578ae
Compare
Uk1288
reviewed
Mar 30, 2023
Co-authored-by: UKEME BASSEY <ukeme.bassey@hashicorp.com>
Uk1288
approved these changes
Mar 30, 2023
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #834
Description
Address #834 - only set
oauth_token_idandgithub_app_installation_idif configured. Before this change, they'd be set to an empty string.Testing plan
tfe_workspacewithvcs_repo.oauth_token_idexplicitly set tonull"oauth-token-id": "",, instead of the expected"oauth-token-id": null,External links
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.