Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated fields, Update Documentation, and Upgrade Go version to 1.17 #114

Merged
merged 14 commits into from
Aug 8, 2022
Merged

Remove deprecated fields, Update Documentation, and Upgrade Go version to 1.17 #114

merged 14 commits into from
Aug 8, 2022

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Aug 4, 2022

What?

  • Removes deprecated fields from resources and replace them with corresponding context fields
  • Upgrades Go version to 1.17
  • Updates CONTRIBUTING.md and README.md to add more/clearer documentation and add SUPPORT.md

Closes #102
Closes #90
Closes #50

@SBGoods SBGoods requested a review from a team as a code owner August 4, 2022 20:16
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 4, 2022
bendbennett
bendbennett reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Looks really good.
Couple of minor comments but looking great.

.go-version Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
internal/tftime/resource_time_offset.go Outdated Show resolved Hide resolved
internal/tftime/resource_time_rotating.go Outdated Show resolved Hide resolved
internal/tftime/resource_time_static.go Outdated Show resolved Hide resolved
@bendbennett bendbennett mentioned this pull request Aug 5, 2022
Merged
@SBGoods SBGoods requested review from bendbennett and a team August 5, 2022 15:07
bendbennett
bendbennett approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SBGoods SBGoods merged commit 4f5f4ed into main Aug 8, 2022
@SBGoods SBGoods deleted the RemoveDeprecatedFields branch August 8, 2022 20:48
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
2 participants
@SBGoods @bendbennett