Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Development/Build Minimum Go Version to 1.17 #188

Closed
1 task done
bflad opened this issue Apr 11, 2022 · 2 comments
Closed
1 task done

Bump Development/Build Minimum Go Version to 1.17 #188

bflad opened this issue Apr 11, 2022 · 2 comments
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Apr 11, 2022

Terraform CLI and Provider Versions

N/A (main branch development)

Use Cases or Problem Statement

Following the Go support policy and given the ecosystem availability and stability of the latest Go minor version, it's time to upgrade. This will ensure that this project can use recent improvements to the Go runtime, standard library functionality, and continue to receive security updates

Proposal

  • Run the following commands to upgrade the Go module files and remove deprecated syntax such as //+build:
go mod edit -go=1.17
go mod tidy
go fix
  • Ensure any GitHub Actions workflows (.github/workflows/*.yml) use 1.18 in place of any 1.17 and 1.17 in place of any 1.16 or earlier
  • Ensure the README or any Contributing documentation notes the Go 1.17 expected minimum
  • (Not applicable to all projects) Ensure the .go-version is at least 1.17 or later
  • Enable the tenv linter in .golangci.yml and remediate any issues.

How much impact is this issue causing?

Medium

Additional Information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@detro detro added this to the next.minor milestone Apr 28, 2022
@detro
Copy link
Contributor

detro commented May 11, 2022

I have reviewed all the items in this proposal, and concluded they have all been addressed in the recent changes applied to this provider.

The only addition I'd make here, and I somehow feel it was implied, is that we should at least be building against the next stable version of Go.

So, if 1.17 is what we build and release against today, we should also build 1.18 in our CI for future-proofing.

Will provide a PR shortly.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants