Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Golang.Go version 1.18 #54491

Merged
3 commits merged into from
Mar 19, 2022
Merged

Add Golang.Go version 1.18 #54491

3 commits merged into from
Mar 19, 2022

Conversation

marcauberer
Copy link
Contributor

@marcauberer marcauberer commented Mar 15, 2022 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Mar 15, 2022
@marcauberer @ItzLevvie
Update manifests/g/GoLang/Go/1.18.0/GoLang.Go.installer.yaml
8faf815 
Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Mar 15, 2022
@marcauberer @ItzLevvie
Update manifests/g/GoLang/Go/1.18.0/GoLang.Go.installer.yaml
ff3c512 
Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 15, 2022
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 54491 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 54491 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Static-Scan The test that runs static analysis failed. label Mar 16, 2022
@ghost
Copy link

ghost commented Mar 16, 2022

Hello @marcauberer,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 16, 2022
@ghost ghost assigned hackean-msft Mar 16, 2022
@wingetbot wingetbot added the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Mar 16, 2022
@ghost
Copy link

ghost commented Mar 16, 2022

Hello @marcauberer,
The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to pass the Installers Scan test. This test is designed to ensure that the application installs on all environments without warnings. For more details on this error, see Binary validation errors. Please check to ensure the installer URL is correct and update the URL and the Hash if a change is made.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Mar 16, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Binary-Validation-Error Indicates and error was encountered during InstallerScan test. Internal-Error-Static-Scan The test that runs static analysis failed. labels Mar 16, 2022
@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Mar 16, 2022
@marcauberer
Copy link
Contributor Author

I assume this is a pipeline bug. Seems like the pipeline is unhealthy at the moment, as the badge above suggests ...
So I am waiting for the pipeline to re-run the check

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 17, 2022
@msftrubengu
Copy link
Contributor

/azp run

@ghost ghost removed Binary-Validation-Error Indicates and error was encountered during InstallerScan test. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 19, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 19, 2022
@ghost
Copy link

ghost commented Mar 19, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Mar 19, 2022

Hello @marcauberer,
Validation has completed.

@ghost ghost merged commit 474b520 into microsoft:master Mar 19, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This was referenced Apr 11, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcauberer @wingetbot @msftrubengu @ItzLevvie @hackean-msft