QoL: Enabling Golang static code analysis with golangci-lint

[detro]

Context: https://github.com/hashicorp/terraform-providers-devex-internal/issues/94

Description

I'm setting up golangci-lint with the all the defaults enabled, plus some extras. Follows a list of errors that were fixed, separated by "what caught them".

Default linters (defined here)

internal/provider/data_source_public_key.go:82:7: Error return value of `d.Set` is not checked (errcheck)
	d.Set("algorithm", keyAlgo)
	     ^
internal/provider/resource_cert_request.go:137:7: Error return value of `d.Set` is not checked (errcheck)
	d.Set("cert_request_pem", certReqPem)
	     ^
internal/provider/resource_certificate.go:199:7: Error return value of `d.Set` is not checked (errcheck)
	d.Set("cert_pem", certPem)
	     ^
internal/openssh/lib_test.go:29:17: ineffectual assignment to err (ineffassign)
	rawPrivateKey, err := ssh.ParseRawPrivateKey(pemOpenSSHPrvKeyBytes)
	               ^
internal/openssh/lib_test.go:61:17: ineffectual assignment to err (ineffassign)
	rawPrivateKey, err := ssh.ParseRawPrivateKey(pemOpenSSHPrvKeyBytes)
	               ^
internal/openssh/lib_test.go:88:17: ineffectual assignment to err (ineffassign)
	rawPrivateKey, err := ssh.ParseRawPrivateKey(pemOpenSSHPrvKeyBytes)
	               ^
internal/provider/data_source_public_key.go:56:2: SA4006: this value of `bytes` is never used (staticcheck)
	bytes := []byte("")
...

deadcode, exportloopref, godot, gofmt, gosimple, govet, ineffassign, makezero, misspell, nilerr, staticcheck, structcheck, unconvert, unparam, unused, varcheck

internal/provider/resource_private_key.go:21:22: Comment should end in a period (godot)
// selected algorithm
                     ^
internal/provider/resource_private_key.go:25:39: Comment should end in a period (godot)
// according to the selected algorithm
                                      ^
internal/provider/types.go:3:56: Comment should end in a period (godot)
// Algorithm represents a type of private key algorithm
                                                       ^
internal/provider/resource_certificate.go:135: File is not `gofmt`-ed with `-s` (gofmt)
		"set_subject_key_id": &schema.Schema{
internal/provider/provider.go:35:72: nameFromResourceData - result 1 (error) is always nil (unparam)
func nameFromResourceData(nameMap map[string]interface{}) (*pkix.Name, error) {
                                                                       ^

predeclared, durationcheck, errcheck

internal/provider/resource_certificate.go:148:45: Multiplication of durations: `time.Duration(d.Get("validity_period_hours").(int)) * time.Hour` (durationcheck)
	template.NotAfter = template.NotBefore.Add(time.Duration(d.Get("validity_period_hours").(int)) * time.Hour)
	                                           ^
internal/provider/resource_certificate.go:234:25: Multiplication of durations: `time.Duration(-d.Get("early_renewal_hours").(int)) * time.Hour` (durationcheck)
		earlyRenewalPeriod := time.Duration(-d.Get("early_renewal_hours").(int)) * time.Hour

Links

• https://golangci-lint.run/usage/linters/
• https://github.com/hashicorp/terraform-plugin-sdk/blob/main/.golangci.yml

[bookshelfdave]

lgtm 👍 , just a few misc questions

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.