Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Golang 1.17 #156

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Upgrading to Golang 1.17 #156

merged 5 commits into from
Mar 4, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Mar 1, 2022

Context: https://github.com/hashicorp/terraform-providers-devex-internal/issues/94

As part of this, I have also enabled tenv provided by GolangCi Lint.

@github-actions github-actions bot added size/M and removed size/S labels Mar 1, 2022
@detro detro changed the title [WIP] Upgrading to Golang 1.17 Upgrading to Golang 1.17 Mar 1, 2022
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@detro detro merged commit eb5ea42 into main Mar 4, 2022
@detro detro deleted the detro/QoL-upgrade_to_golang_1.17 branch March 4, 2022 13:29
@detro detro added this to the v3.2.0 milestone Mar 16, 2022
@detro detro added the go Pull requests that update Go code label Mar 18, 2022
@detro detro self-assigned this Mar 30, 2022
jackivanov pushed a commit to jackivanov/terraform-provider-tls that referenced this pull request Aug 4, 2022
* Updating to Go 1.17.7 (and `go mod tidy`)

* Updating "Test" GH Action

* Updating go version info in README

* Enabling `tenv` GolangCI LInting

* Updating `x/crypto` dependency (and sub-dependencies)
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies go Pull requests that update Go code size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants