Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove legacy behavior from private_key_pem attribute docs #366

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

austinvalle
Copy link
Member

Closes #365

PR #215 updated the private_key_pem attribute to be stored as-is to reflect HashiCorp's guidance of avoiding encrypting state, however the documentation was not updated to reflect this new behavior.

@austinvalle austinvalle requested a review from a team as a code owner June 6, 2023 16:04
@austinvalle austinvalle added this to the v4.1.0 milestone Jun 6, 2023
@austinvalle austinvalle changed the title Remove legacy behavior from private_key_pem attribute docs documentation: remove legacy behavior from private_key_pem attribute docs Jun 6, 2023
@austinvalle austinvalle changed the title documentation: remove legacy behavior from private_key_pem attribute docs docs: remove legacy behavior from private_key_pem attribute docs Jun 6, 2023
@austinvalle austinvalle merged commit 4d0d5c4 into main Jun 6, 2023
31 checks passed
@austinvalle austinvalle deleted the av/fix-docs branch June 6, 2023 17:12
@austinvalle austinvalle modified the milestones: v4.1.0, v4.0.5 Nov 27, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tls_cert_request stores plaintext private_key_pem in state
2 participants