Expand PR899 to also cover Entity Groups #1010

yermulnik · 2021-03-23T18:04:41Z

[resource_identity_entity.go] Log Wrote IdentityEntity only when resp != nil
[resource_identity_group.go] Catch empty response in identityGroupCreate() and prompt to import existing resource
[resource_identity_group.go] Add identityGrpupNamePath() function to align with resource_identity_entity.go
[identity_group.html.md] Add import details

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

BUG FIXES:
* `resource/vault_identity_group`: Fix nil pointer exception when attempting to create Identity Group which already exists ([#1010](https://github.com/hashicorp/terraform-provider-vault/pull/1010))

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIdentityGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIdentityGroup -timeout 120m
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccIdentityGroupAlias
--- PASS: TestAccIdentityGroupAlias (11.17s)
=== RUN   TestAccIdentityGroupAliasUpdate
--- PASS: TestAccIdentityGroupAliasUpdate (19.20s)
=== RUN   TestAccIdentityGroupMemberEntityIdsExclusiveEmpty
--- PASS: TestAccIdentityGroupMemberEntityIdsExclusiveEmpty (29.25s)
=== RUN   TestAccIdentityGroupMemberEntityIdsExclusive
    resource_identity_group_member_entity_ids_test.go:51: &{{{{0 0} 0 0 0 0} [] {0xc0022ffe00} false false false false map[] map[] []  [] 0xc00048d5c0 false false 0 0 testing.tRunner 0xc000103200 1 [17984120 17963375 17970430 17965803 31229432 17024246 17250081] TestAccIdentityGroupMemberEntityIdsExclusive {13839184608674777960 59620865687 0x29b4520} 0 0xc000279b00 0xc0003c8a80 [] {0 0}  <nil> 0} false 0xc000148ff0}
--- SKIP: TestAccIdentityGroupMemberEntityIdsExclusive (0.00s)
=== RUN   TestAccIdentityGroupMemberEntityIdsNonExclusiveEmpty
--- PASS: TestAccIdentityGroupMemberEntityIdsNonExclusiveEmpty (30.76s)
=== RUN   TestAccIdentityGroupMemberEntityIdsNonExclusive
    resource_identity_group_member_entity_ids_test.go:121: &{{{{0 0} 0 0 0 0} [] {0xc004708900} false false false false map[] map[] []  [] 0xc00048d5c0 false false 0 0 testing.tRunner 0xc000103200 1 [17984120 17963375 17970430 17965803 31229432 17024246 17250081] TestAccIdentityGroupMemberEntityIdsNonExclusive {13839184641725862504 90385257859 0x29b4520} 0 0xc004172ba0 0xc004172c00 [] {0 0}  <nil> 0} false 0xc000148ff0}
--- SKIP: TestAccIdentityGroupMemberEntityIdsNonExclusive (0.00s)
=== RUN   TestAccIdentityGroupPoliciesExclusive
--- PASS: TestAccIdentityGroupPoliciesExclusive (18.38s)
=== RUN   TestAccIdentityGroupPoliciesNonExclusive
--- PASS: TestAccIdentityGroupPoliciesNonExclusive (19.97s)
=== RUN   TestAccIdentityGroup
--- PASS: TestAccIdentityGroup (9.79s)
=== RUN   TestAccIdentityGroupUpdate
--- PASS: TestAccIdentityGroupUpdate (41.19s)
=== RUN   TestAccIdentityGroupExternal
--- PASS: TestAccIdentityGroupExternal (9.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	190.247s

hashicorp-cla · 2021-03-23T18:04:44Z

All committers have signed the CLA.

yermulnik · 2021-03-23T18:16:05Z

Build error looks unrelated:

=== RUN   TestTerraformCloudSecretBackend
--- FAIL: TestTerraformCloudSecretBackend (0.09s)
    testing.go:669: Step 0 error: errors during apply:
        
        Error: Error mounting to "tf-test-terraform-cloud-3576202624928866464": Error making API request.
        
        URL: POST http://127.0.0.1:8200/v1/sys/mounts/tf-test-terraform-cloud-3576202624928866464
        Code: 400. Errors:
        
        * plugin not found in the catalog: terraform
        
          on /tmp/tf-test244151559/main.tf line 2:
          (source code not available)
        
        
=== RUN   TestAccResourceTerraformCloudSecretCredsOrganizationBasic
--- SKIP: TestAccResourceTerraformCloudSecretCredsOrganizationBasic (0.00s)
    resource_terraform_cloud_secret_creds_test.go:27: TF_TOKEN and TF_ORGANIZATION must be set. Are currently  and  respectively
=== RUN   TestAccResourceTerraformCloudSecretCredsTeamBasic
--- SKIP: TestAccResourceTerraformCloudSecretCredsTeamBasic (0.00s)
    resource_terraform_cloud_secret_creds_test.go:56: TF_TOKEN, TF_ORGANIZATION, and TF_TEAM_ID must be set. Are currently ,  and  respectively
=== RUN   TestAccResourceTerraformCloudSecretCredsUserBasic
--- SKIP: TestAccResourceTerraformCloudSecretCredsUserBasic (0.00s)
    resource_terraform_cloud_secret_creds_test.go:85: TF_TOKEN and TF_USER_ID must be set. Are currently  and  respectively
=== RUN   TestTerraformCloudSecretRole
--- FAIL: TestTerraformCloudSecretRole (0.12s)
    testing.go:669: Step 0 error: errors during apply:
        
        Error: Error mounting to "tf-test-backend-4025106427670301869": Error making API request.
        
        URL: POST http://127.0.0.1:8200/v1/sys/mounts/tf-test-backend-4025106427670301869
        Code: 400. Errors:
        
        * plugin not found in the catalog: terraform
        
          on /tmp/tf-test081643217/main.tf line 2:
          (source code not available)

jasonodonnell · 2021-06-16T15:51:32Z

Hi @yermulnik, thanks for the contribution. Yes that CI is unrelated.

We're unable to merge this PR without the CLA being signed. Are you able to do so?

Thanks!

yermulnik · 2021-06-16T18:46:31Z

@jasonodonnell Oops, I somehow missed that comment from the bot. Just went through signing step. Could you please verify whether it completed with success?

benashz · 2021-07-23T14:41:16Z

Hi @yermulnik , this PR is looking good. Would you mind updating the changelog message a bit.

Suggestion:

fix: handle preexisting identity_group

* detect preexisting identity group prior to creation, and
  suggest importing the resource in this case.

yermulnik · 2021-07-23T14:50:30Z

Hi @benashz,
Yep, no problem. Do you mean to edit my initial message up above (Release note for CHANGELOG:)?
Or you mean the CHANGELOG.md per se? (which I'd be a bit confused with since I don't know what Release version this PR will be a part of)

benashz · 2021-07-23T14:56:13Z

Yep, no problem. Do you mean to edit my initial message up above (Release note for CHANGELOG:)?

No, I was referring to your commit message:

git commit --amend

Or you mean the CHANGELOG.md per se? (which I'd be a bit confused with since I don't know what Release version this PR will be a part of)

No need to modify CHANGELOG.md, we will take care of that when this PR is merged.

yermulnik · 2021-07-23T15:09:44Z

@benashz Done

website/docs/r/identity_group.html.md

* detect preexisting identity group prior to creation, and suggest importing the resource in this case.

benashz

LGTM! Thank you for your contribution to HashiCorp!

* detect preexisting identity group prior to creation, and suggest importing the resource in this case.

ghost added size/XS documentation labels Mar 23, 2021

yermulnik mentioned this pull request Mar 23, 2021

Fix Terraform crash when creating an entity that already exists #899

Merged

benashz self-requested a review July 23, 2021 14:23

github-actions bot added size/S and removed size/XS labels Jul 23, 2021

benashz reviewed Jul 23, 2021

View reviewed changes

website/docs/r/identity_group.html.md Outdated Show resolved Hide resolved

fix: handle preexisting identity_group

9b38f43

* detect preexisting identity group prior to creation, and suggest importing the resource in this case.

benashz approved these changes Jul 23, 2021

View reviewed changes

benashz merged commit 7d09bf0 into hashicorp:master Jul 23, 2021

yermulnik deleted the expand_pr899_to_cover_entity_groups branch July 23, 2021 16:32

davidmontoyago pushed a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021

fix: handle preexisting identity_group (hashicorp#1010)

654d5ac

* detect preexisting identity group prior to creation, and suggest importing the resource in this case.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand PR899 to also cover Entity Groups #1010

Expand PR899 to also cover Entity Groups #1010

yermulnik commented Mar 23, 2021 •

edited

hashicorp-cla commented Mar 23, 2021 •

edited

yermulnik commented Mar 23, 2021

jasonodonnell commented Jun 16, 2021

yermulnik commented Jun 16, 2021

benashz commented Jul 23, 2021

yermulnik commented Jul 23, 2021 •

edited

benashz commented Jul 23, 2021

yermulnik commented Jul 23, 2021

benashz left a comment

Expand PR899 to also cover Entity Groups #1010

Expand PR899 to also cover Entity Groups #1010

Conversation

yermulnik commented Mar 23, 2021 • edited

Community Note

hashicorp-cla commented Mar 23, 2021 • edited

yermulnik commented Mar 23, 2021

jasonodonnell commented Jun 16, 2021

yermulnik commented Jun 16, 2021

benashz commented Jul 23, 2021

yermulnik commented Jul 23, 2021 • edited

benashz commented Jul 23, 2021

yermulnik commented Jul 23, 2021

benashz left a comment

Choose a reason for hiding this comment

yermulnik commented Mar 23, 2021 •

edited

hashicorp-cla commented Mar 23, 2021 •

edited

yermulnik commented Jul 23, 2021 •

edited