Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes auth role: allow unset audience #1022

Merged
merged 1 commit into from May 19, 2021
Merged

kubernetes auth role: allow unset audience #1022

merged 1 commit into from May 19, 2021

Conversation

davidmontoyago
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #868

Release note for CHANGELOG:

resource/vault_kubernetes_auth_backend_role: allow unset audience.

Output from acceptance testing:

TF_ACC=1 go test -v github.com/hashicorp/terraform-provider-vault/vault -run TestAccKubernetesAuthBackendRole_fullUpdate

--- PASS: TestAccKubernetesAuthBackendRole_fullUpdate (43.02s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     43.581s
...

@ghost ghost added size/S labels Apr 11, 2021
@tvoran tvoran self-requested a review May 8, 2021 00:36
tvoran
tvoran approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@tvoran tvoran merged commit 01a25f5 into hashicorp:master May 19, 2021
davidmontoyago added a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021
@davidmontoyago
kubernetes auth role: allow unset audience (hashicorp#1022)
edb70ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault_kubernetes_auth_backend_role audience field cannot be unset
2 participants
@davidmontoyago @tvoran