Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate the provider's namespace throughout #1107

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 21, 2021

  • ensure that all Vault resources are provisioned under the namespace of
    the provider.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make dev testacc TF_ACC_ENTERPRISE=1 TESTARGS='-run \^TestAccAppRoleAuthBackendRoleSecretI'
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run \^TestAccAppRoleAuthBackendRoleSecretI -timeout 120m

[...]

=== RUN   TestAccAppRoleAuthBackendRoleSecretID_basic
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_basic (0.24s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_wrapped
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_wrapped (0.23s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_wrapped_namespace
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_wrapped_namespace (0.34s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_full
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_full (0.22s)
PASS

[...]

* ensure that all Vault resources are provisioned under the namespace of
  the provider.
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question in the test.

@benashz benashz force-pushed the benashz/vault-1065-fix-wrapped-ns branch from fc784d6 to 0e8abc2 Compare July 22, 2021 13:02
@benashz benashz merged commit f652207 into master Jul 22, 2021
@benashz benashz deleted the benashz/vault-1065-fix-wrapped-ns branch July 22, 2021 13:14
davidmontoyago pushed a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021
* ensure that all Vault resources are provisioned under the namespace of
  the provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants