Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support importing okta_auth_backend resource #1123

Merged
merged 14 commits into from
Aug 2, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #796

Release note for CHANGELOG:

resource/okta_auth_backend`: Support importing preexisting resource 

Output from acceptance testing:

make dev testacc TESTARGS='-run \^TestAccOktaAuthBackend_'
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./...) -v -run \^TestAccOktaAuthBackend_ -timeout 120m

[...]

=== RUN   TestAccOktaAuthBackend_basic
--- PASS: TestAccOktaAuthBackend_basic (0.42s)
=== RUN   TestAccOktaAuthBackend_import
--- PASS: TestAccOktaAuthBackend_import (0.33s)
=== RUN   TestAccOktaAuthBackend_invalid_ttl
--- PASS: TestAccOktaAuthBackend_invalid_ttl (0.02s)
=== RUN   TestAccOktaAuthBackend_invalid_max_ttl
--- PASS: TestAccOktaAuthBackend_invalid_max_ttl (0.02s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     2.393s

vault/resource_okta_auth_backend.go Outdated Show resolved Hide resolved
vault/resource_okta_auth_backend.go Show resolved Hide resolved
vault/resource_okta_auth_backend.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/XL and removed size/L labels Jul 30, 2021
@github-actions github-actions bot added size/L and removed size/XL labels Jul 30, 2021
vault/resource_okta_auth_backend.go Outdated Show resolved Hide resolved
@benashz benashz merged commit bcfb791 into master Aug 2, 2021
davidmontoyago pushed a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021
* add  validation for ttl and max_ttl imputs

* add some missing backend configuration fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support import for vault_okta_auth_backend
3 participants