Update api.Client for isolated read-after-write support #1188

benashz · 2021-10-07T20:55:39Z

This PR adds support for the Vault client API's Client Controlled Consistency model. It utilizes a shared store for tracking the replication state for all client instances.

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1170 hashicorp/vault#12814

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

- The ClientFactory provide a consistent interface for managing vault Client instances. It provides a shared replication state store that supports the Vault client API's Client Controlled Consistency model.

go.mod

vault/client.go

vault/client_test.go

vault/client.go

vault/client_test.go

This reverts commit 7f97055.

benashz added 3 commits October 7, 2021 16:21

fix: add a Vault client factory for triple-C support

7f97055

- The ClientFactory provide a consistent interface for managing vault Client instances. It provides a shared replication state store that supports the Vault client API's Client Controlled Consistency model.

fix: update all resources to use the ClientFactory

44dd95f

fix: build: only run tests under ./vault

928ca3c

github-actions bot added dependencies size/XL labels Oct 7, 2021

kalafut requested a review from ncabatoff October 7, 2021 21:21

benashz requested a review from vinay-gopalan October 7, 2021 21:35

vinay-gopalan reviewed Oct 7, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

vinay-gopalan mentioned this pull request Oct 7, 2021

[VAULT-3157] Add X-Vault-Index header functionality #1170

Closed

fix: better tests for Client()

55678ef

calvn reviewed Oct 8, 2021

View reviewed changes

tomhjp reviewed Oct 8, 2021

View reviewed changes

vault/client.go Outdated Show resolved Hide resolved

vault/client.go Outdated Show resolved Hide resolved

benashz and others added 4 commits October 8, 2021 11:28

Post review updates round 1.

7eecf24

Drop ClientFactory.init()

3fd937c

resolve merge conflicts

b705d94

Add cloning tests for ClientFactory

1dbe346

benashz commented Oct 8, 2021

View reviewed changes