Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contained_db field to mssql db secret backend #1259

Merged
merged 9 commits into from Dec 17, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Dec 14, 2021

In addition the following updates were made

  • run mssql database secret backend connection tests against a local
    mssql docker container
  • factor out db backend types to constants
  • update canonical list of db backend types to include all supported
    types
  • add ability to skip db tests globally or based on the db engine type

Dependency updates:

  • terraform-plugin-sdk/v2 to v2.10.0
  • vault/api v1.3.0
  • vault/sdk v0.3.1-0.20211214161113-fcc5f22bea02
  • vault v1.2.1-0.20211214161113-fcc5f22bea02

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1237

Release note for CHANGELOG:


Output from acceptance testing:

 make dev testacc TESTARGS='-v -test.run TestAccDatabaseSecretBackendConnection_mssql'
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./...) -v -v -test.run TestAccDatabaseSecretBackendConnection_mssql -timeout 20m

[...]

=== RUN   TestAccDatabaseSecretBackendConnection_mssql
--- PASS: TestAccDatabaseSecretBackendConnection_mssql (13.97s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     14.782s

In addition the following updates were made
- run mssql database secret backend connection tests against a local
  mssql docker container
- factor out db backend types to constants
- update canonical list of db backend types to include all supported
  types
- add ability to skip db tests globally or based on the db engine type

Dependency updates:
- terraform-plugin-sdk/v2 to v2.10.0
- vault/api v1.3.0
- vault/sdk v0.3.1-0.20211214161113-fcc5f22bea02
- vault v1.2.1-0.20211214161113-fcc5f22bea02
@benashz benashz force-pushed the VAULT-4404/add-contain_db-to-db-secret-backend-conn branch from 22838bc to 042d193 Compare December 14, 2021 22:38
@benashz benashz changed the title Add contain_db field to mssql db secret backend Add contained_db field to mssql db secret backend Dec 16, 2021
- Work around issue where the mssql plugin cannot accept a boolean value
  for the `contained_db` field.
@benashz benashz merged commit fc67598 into main Dec 17, 2021
@benashz benashz deleted the VAULT-4404/add-contain_db-to-db-secret-backend-conn branch December 17, 2021 21:18
@benashz benashz added this to the 3.1.0 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_database_secret_backend_connection missing contained_db field for MSSQL database
2 participants