-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add organization_id field to github_auth_backend (vault-1.10+) #1296
Add organization_id field to github_auth_backend (vault-1.10+) #1296
Conversation
- Update the github_auth_backend resource to accept the `organization_id` field for Vault 1.10+ - Add new GitHub API helper to `testutil`
7cebe1c
to
b7873d1
Compare
} | ||
|
||
// cache GH API responses to avoid triggering the GH request rate limiter | ||
var ghOrgResponseCache = map[string]*GHOrgResponse{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@benashz code looks good! Do I need to set any env vars to run the tests? All my tests are failing wherever
|
Odd, the tests are passing for me (see below). Let's sync up today.
|
9c0ec64
to
ffe96ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Add
organization_id
field to the github_auth_backend resourceorganization_id
field for Vault 1.10+testutil
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: