Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check to resolve panic when reading RabbitMQ role from Vault #1312

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Add nil check to resolve panic when reading RabbitMQ role from Vault #1312

merged 4 commits into from
Jan 20, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Jan 20, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1309

Release note for CHANGELOG:

`resource/rabbitmq_secret_backend_role`: Add nil check when reading RabbitMQ role from Vault

Output from acceptance testing:

$  make testacc TESTARGS='-v -run TestAccRabbitMQSecretBackendRole'
=== RUN   TestAccRabbitMQSecretBackendRole_basic
--- PASS: TestAccRabbitMQSecretBackendRole_basic (3.32s)
=== RUN   TestAccRabbitMQSecretBackendRole_nested
--- PASS: TestAccRabbitMQSecretBackendRole_nested (3.28s)
=== RUN   TestAccRabbitMQSecretBackendRole_topic
--- PASS: TestAccRabbitMQSecretBackendRole_topic (3.35s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     10.350s

benashz
benashz reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, added a few comments/suggestions.

vault/resource_rabbitmq_secret_backend_role.go Outdated Show resolved Hide resolved
vault/resource_rabbitmq_secret_backend_role.go Outdated Show resolved Hide resolved
benashz
benashz approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz merged commit 09079bf into main Jan 20, 2022
@benashz benashz deleted the VAULT-4827/fix-vhost-topic-nil branch January 20, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider Crashing on v3.2.0
2 participants
@vinay-gopalan @benashz