Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disable_escaping parameter for select DB Engines #1321

Merged
merged 9 commits into from
Feb 14, 2022
Merged

Add support for disable_escaping parameter for select DB Engines #1321

merged 9 commits into from
Feb 14, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Jan 26, 2022 •
edited

This PR adds support for the disable_escaping field to Redshift, MSSQL, Postgres and HanaDB in order to fully support templated connection URLs in the Provider.

Relates OR Closes #4770

Release note for CHANGELOG:

`resource/database_secret_backend_connection`: Add support for the `username`, `password` and `disable_escaping` fields to Redshift, MSSQL, Postgres and HanaDB

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_mssql'
=== RUN   TestAccDatabaseSecretBackendConnection_mssql
--- PASS: TestAccDatabaseSecretBackendConnection_mssql (8.67s)
PASS

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_postgresql
=== RUN   TestAccDatabaseSecretBackendConnection_postgresql
--- PASS: TestAccDatabaseSecretBackendConnection_postgresql (1.69s)
PASS

@vinay-gopalan vinay-gopalan changed the base branch from main to release/vault-next January 27, 2022 18:45
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 28, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@vinay-gopalan vinay-gopalan marked this pull request as ready for review January 28, 2022 21:22
@vinay-gopalan vinay-gopalan changed the title Add support for templated connection URLs for select DB Engines Add support for disable_escaping parameter for select DB Engines Feb 11, 2022
benashz
benashz reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits.

We also need to update the website docs.

vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
vault/resource_database_secret_backend_connection_test.go Outdated Show resolved Hide resolved
benashz
benashz reviewed Feb 14, 2022
View reviewed changes
website/docs/r/database_secret_backend_connection.md
@@ -167,6 +167,10 @@ Exactly one of the nested blocks of configuration options must be supplied.
docs](https://www.vaultproject.io/api-docs/secret/databases/mongodb.html#sample-payload)
for an example.

* `username` - (Optional) The root credential username used in the connection URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks we missed these in the related PR. We should probably open a new PR to main that includes the username and password docs, otherwise we will have to wait until vault-1.10 is released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benashz good call. I created another PR to be merged to main here #1344

benashz
benashz approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit 90a1969 into release/vault-next Feb 14, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-4075/add-disable-escaping branch February 14, 2022 20:21
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@vinay-gopalan
Add support for disable_escaping parameter for select DB Engines (h…
cb31668 
…ashicorp#1321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinay-gopalan @hashicorp-cla @benashz