-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disable_escaping
parameter for select DB Engines
#1321
Add support for disable_escaping
parameter for select DB Engines
#1321
Conversation
…, postgres and mssql
disable_escaping
parameter for select DB Engines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits.
We also need to update the website docs.
@@ -167,6 +167,10 @@ Exactly one of the nested blocks of configuration options must be supplied. | |||
docs](https://www.vaultproject.io/api-docs/secret/databases/mongodb.html#sample-payload) | |||
for an example. | |||
|
|||
* `username` - (Optional) The root credential username used in the connection URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks we missed these in the related PR. We should probably open a new PR to main that includes the username
and password
docs, otherwise we will have to wait until vault-1.10 is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds support for the
disable_escaping
field to Redshift, MSSQL, Postgres and HanaDB in order to fully support templated connection URLs in the Provider.Relates OR Closes #4770
Release note for CHANGELOG:
Output from acceptance testing: