Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto_rotate_interval to Transit Key backend #1345

Merged
merged 6 commits into from
Feb 28, 2022
Merged

Add auto_rotate_interval to Transit Key backend #1345

merged 6 commits into from
Feb 28, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Feb 15, 2022 •
edited

This PR adds an auto_rotate_interval field to the Transit Secret Backend Key resource.
Corresponding Vault PR: hashicorp/vault#13691

Output from Acceptance Tests:

$ make testacc TESTARGS='-v -run TestTransitSecretBackendKey'
=== RUN   TestTransitSecretBackendKey_basic
--- PASS: TestTransitSecretBackendKey_basic (4.71s)
=== RUN   TestTransitSecretBackendKey_rsa4096
--- PASS: TestTransitSecretBackendKey_rsa4096 (5.53s)
=== RUN   TestTransitSecretBackendKey_import
--- PASS: TestTransitSecretBackendKey_import (2.13s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     13.264s

@vinay-gopalan vinay-gopalan marked this pull request as ready for review February 15, 2022 22:46
benashz
benashz reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Probably want to investigate the build failure however.

vault/resource_transit_secret_backend_key.go Show resolved Hide resolved
vault/resource_transit_secret_backend_key_test.go Outdated Show resolved Hide resolved
website/docs/r/transit_secret_backend_key.html.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/L and removed size/M labels Feb 28, 2022
benashz
benashz approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit 2ada049 into release/vault-next Feb 28, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-4815/transit-autorotate-interval branch February 28, 2022 23:24
@vinay-gopalan vinay-gopalan added this to the 3.4.0 milestone Mar 15, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@vinay-gopalan
Add auto_rotate_interval to Transit Key backend (hashicorp#1345)
d4643b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinay-gopalan @benashz