Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Consul roles #1366

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Add support for Consul roles #1366

merged 4 commits into from
Mar 3, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Mar 2, 2022

Update the consul_secret_backend_role resource to support Consul roles.

Output from acceptance testing:

$ make testacc TESTARGS='-v -test.run TestConsul'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -v -test.run TestConsul -timeout 30m ./...
=== RUN   TestConsulSecretBackendRole
--- PASS: TestConsulSecretBackendRole (3.37s)
=== RUN   TestConsulSecretBackendRoleNameFromPath
--- PASS: TestConsulSecretBackendRoleNameFromPath (0.00s)
=== RUN   TestConsulSecretBackendRoleBackendFromPath
--- PASS: TestConsulSecretBackendRoleBackendFromPath (0.00s)
=== RUN   TestConsulSecretBackend
--- PASS: TestConsulSecretBackend (6.77s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     13.025s

@benashz
Add support for Consul roles
fc2ad49 
Update the consul_secret_backend_role resource to support Consul roles.
@benashz benashz added this to the vault-1.10 milestone Mar 2, 2022
@github-actions github-actions bot added the size/L label Mar 2, 2022
vinay-gopalan
vinay-gopalan approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan self-requested a review March 3, 2022 18:59
@benashz benashz merged commit 8ef7e76 into release/vault-next Mar 3, 2022
@benashz benashz deleted the VAULT-4968/consul-secrets-add-roles-support branch March 3, 2022 19:24
@benashz benashz mentioned this pull request Mar 3, 2022
Closed
@benashz benashz modified the milestones: vault-1.10, 3.4.0 Mar 15, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz
Add support for Consul roles (hashicorp#1366)
c52315b 
Update the consul_secret_backend_role resource to support Consul roles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benashz @vinay-gopalan