Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Consul namespaces and partitions #1367

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add support for Consul namespaces and partitions #1367

merged 2 commits into from
Mar 4, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Mar 3, 2022

Update the consul_secret_backend_role resource to support Consul namespaces and partitions.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
$ make testacc TESTARGS='-v -test.run TestConsul'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -v -test.run TestConsul -timeout 30m ./...

ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestConsulSecretBackendRole
--- PASS: TestConsulSecretBackendRole (4.70s)
=== RUN   TestConsulSecretBackendRoleNameFromPath
--- PASS: TestConsulSecretBackendRoleNameFromPath (0.00s)
=== RUN   TestConsulSecretBackendRoleBackendFromPath
--- PASS: TestConsulSecretBackendRoleBackendFromPath (0.00s)
=== RUN   TestConsulSecretBackend
--- PASS: TestConsulSecretBackend (6.73s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     13.954s

...

@benashz
Add support for Consul namespace and partition
abff649 
Update the consul_secret_backend_role resource to support
Consul namespaces and partitions.
vinay-gopalan
vinay-gopalan reviewed Mar 3, 2022
View reviewed changes
website/docs/r/consul_secret_backend_role.html.md Outdated
@@ -38,10 +38,17 @@ The following arguments are supported:
* `backend` - (Optional) The unique name of an existing Consul secrets backend mount. Must not begin or end with a `/`. One of `path` or `backend` is required.

* `name` - (Required) The name of the Consul secrets engine role to create.

* `consul_namespace` - (Optional) Then Consul namespace that the token will be created in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: same as above

vinay-gopalan
vinay-gopalan approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Short nit about typo in description

@benashz benashz force-pushed the VAULT-4968/consul-secrets-add-ns-support branch from 36b1432 to 94f9505 Compare March 3, 2022 23:36
@benashz benashz merged commit 6a7bc64 into release/vault-next Mar 4, 2022
@benashz benashz deleted the VAULT-4968/consul-secrets-add-ns-support branch March 4, 2022 00:12
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz
Add support for Consul namespaces and partitions (hashicorp#1367)
d995f17 
Update the consul_secret_backend_role resource to support
Consul namespaces and partitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benashz @vinay-gopalan