Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generic secrets data doc #1390

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

brunopadz
Copy link
Contributor

While trying to use this data resource, I've struggled a little to understand how to use it for KV secrets engine. After a bit of reading and unsuccesful attempts, I've noticed that other users are getting confused by the docs (#470).

This PR improves the documentation by adding a new example for KV engine.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #470

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz benashz added this to the 3.5.0 milestone Apr 1, 2022
@benashz benashz removed this from the 3.5.0 milestone Apr 19, 2022
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR and your contribution to HashiCorp!

@vinay-gopalan vinay-gopalan merged commit 53dcdbe into hashicorp:main May 4, 2022
@vinay-gopalan vinay-gopalan added this to the 3.6.0 milestone May 5, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_generic_secret data source documentation is confusing
4 participants