Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when tenant_id and subscription are specified #1391

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Mar 25, 2022

Add environment field to the schema. This can override whatever
environment is set in the Vault backend.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1387

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Add environment field to the schema. This can override whatever
environment is set in the Vault backend.
@benashz benashz merged commit 582c458 into main Mar 28, 2022
@benashz benashz deleted the VAULT-5540/fix-panic-in-d-azure-secret branch March 28, 2022 17:28
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Add environment field to the schema. This can be used to override
whatever environment is set in the Vault backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_azure_access_credentials crashes with subscription_id specified
2 participants