Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transit secret key to support auto_rotate_period #1402

Merged
merged 1 commit into from Apr 5, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Apr 5, 2022

The provider originally shipped with support for the
auto_rotate_interval field, this was subsequently changed in the GA
release of Vault to be auto_rotate_period. This fix deprecates the
former and adds the latter.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-v -test.run TestTransit*'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -v -test.run TestTransit* -timeout 30m ./...

[...]

ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestTransitSecretBackendKey_basic
--- PASS: TestTransitSecretBackendKey_basic (4.94s)
=== RUN   TestTransitSecretBackendKey_rsa4096
--- PASS: TestTransitSecretBackendKey_rsa4096 (8.62s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     14.425s
...

The provider originally shipped with support for the
auto_rotate_interval field, this was subsequently changed in the GA
release of Vault to be auto_rotate_period. This fix deprecates the
former and adds the latter.
@benashz benashz merged commit b83c055 into main Apr 5, 2022
@benashz benashz deleted the VAULT-5711/support-transit-key-auto-rotate-period branch April 5, 2022 19:50
@benashz benashz added this to the 3.5.0 milestone Apr 5, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
The provider originally shipped with support for the
auto_rotate_interval field, this was subsequently changed in the GA
release of Vault to be auto_rotate_period. This fix deprecates the
former and adds the latter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants