Add support for KV Secret Engine resources to move away from `vault_generic_secret` #1457

vinay-gopalan · 2022-05-13T21:56:41Z

This PR adds 3 new resources — vault_kv_secret, vault_kv_secret_v2 and vault_kv_secret_backend_v2 — as well as 5 new data sources — vault_kv_secret, vault_kv_secret_v2, vault_kv_secrets_list, vault_kv_secrets_list_v2 and vault_kv_secret_subkeys_v2 that enable users fully configure secrets for and retrieve secrets from KV V1 and V2 Secret Engines.

Resolves: #1033 #57

make testacc TESTARGS='-v -run TestDataSourceKV' 
=== RUN   TestDataSourceKVSecretList
--- PASS: TestDataSourceKVSecretList (1.95s)
=== RUN   TestDataSourceKVSecretListV2
--- PASS: TestDataSourceKVSecretListV2 (3.55s)
=== RUN   TestDataSourceKVSecret
--- PASS: TestDataSourceKVSecret (1.89s)
=== RUN   TestDataSourceKVV2Secret
--- PASS: TestDataSourceKVV2Secret (1.85s)
=== RUN   TestDataSourceKVSubkeys_basic
--- PASS: TestDataSourceKVSubkeys_basic (1.87s)
PASS

make testacc TESTARGS='-v -run TestAccKV'
=== RUN   TestAccKVSecretBackendV2_basic
--- PASS: TestAccKVSecretBackendV2_basic (3.78s)
=== RUN   TestAccKVSecret_basic
--- PASS: TestAccKVSecret_basic (2.06s)
=== RUN   TestAccKVSecretV2_basic
--- PASS: TestAccKVSecretV2_basic (2.07s)
PASS

benashz

Looking good! Have some suggestions/questions...

website/docs/d/generic_secret_list.html.md

vault/data_source_generic_secret_list.go

website/docs/d/generic_secret_list_v2.html.md

benashz · 2022-05-20T20:54:32Z

vault/data_source_generic_secret_list_test.go

+		PreCheck:  func() { testutil.TestAccPreCheck(t) },
+		Steps: []resource.TestStep{
+			{
+				Config: testDataSourceGenericSecretListConfig(mount, s1, s2, true),


Should we test the failure modes as well?

vault/data_source_generic_secret_list_test.go

website/docs/d/generic_secret_list.html.md

website/docs/d/generic_secret_list_v2.html.md

benashz

Some initial suggestions.

vault/data_source_kv_secret.go

vault/data_source_kv_secret_list.go

vault/data_source_kv_secret_list_test.go

vault/data_source_kv_subkeys_v2.go

vault/data_source_kv_secret_test.go

vault/data_source_kv_secret_v2.go

vault/resource_kv_secret.go

vault/resource_kv_secret_backend_v2_test.go

vault/resource_kv_secret_v2_test.go

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

…raform-provider-vault into VAULT-1336/support-kv-list

benashz

Looks great. Just few minor issues to address, then +1

vault/data_source_kv_secret_test.go

website/docs/d/generic_secret_list.html.md

website/docs/d/generic_secret_list_v2.html.md

website/vault.erb

…eneric_secret` (hashicorp#1457)

add vault_generic_secrets_list resource

fc20f9a

github-actions bot added documentation size/XL labels May 13, 2022

refactor methods to use context funcs and diagnostics

0f6cbd8

github-actions bot added size/L and removed size/XL labels May 18, 2022

split list resource into v1 and v2

990d1c8

github-actions bot added size/XL and removed size/L labels May 19, 2022

vinay-gopalan requested a review from benashz May 19, 2022 22:15

benashz reviewed May 20, 2022

View reviewed changes

vinay-gopalan added 11 commits June 1, 2022 13:57

add new backend and v2 secret resources

96cba88

Merge branch 'main' into VAULT-1336/support-kv-list

c55d291

add KVV2 config resource

0bc0fb6

add kvv2 secret resource

5f5e559

rename from generic -> kv

f3ca8aa

add data source for kv v2 secret

3ef0db9

add kvv2 list data source

ba584fd

add kvv1 resource

3474ce9

update test for list kvv1 secrets

9c60443

add kvv1 secret data source

ad675f6

add kvv2 subkeys data source

88987e3

vinay-gopalan changed the title ~~Add support to list generic secrets~~ Add support for KV Secret Engine resources to move away from generic_secret Jun 3, 2022

vinay-gopalan changed the title ~~Add support for KV Secret Engine resources to move away from generic_secret~~ Add support for KV Secret Engine resources to move away from vault_generic_secret Jun 3, 2022

vinay-gopalan added 4 commits June 3, 2022 01:49

rename list data sources

a8a7207

rename subkeys datasource test

77b2bd2

Merge branch 'main' into VAULT-1336/support-kv-list

9dddf67

update resources and datasources with ProviderMeta

853e692

benashz reviewed Jun 3, 2022

View reviewed changes

add docs for KV-V1 secret resource and data source

c0bbcaf

vinay-gopalan added 4 commits June 10, 2022 15:30

replace strings with constant field names

cde534d

add missing package in KMIP role file

f1c4f4c

fix conflicting package names

5fda7e5

make subkeys a JSON string

dfbfa99

vinay-gopalan requested a review from benashz June 13, 2022 20:58

vinay-gopalan added 2 commits June 13, 2022 14:50

add CheckJSONData in testutil

5512189

resolve merge conflicts

b6a0543

benashz reviewed Jun 14, 2022

View reviewed changes

vinay-gopalan and others added 10 commits June 14, 2022 10:17

Update vault/data_source_kv_secret_v2.go

cb07b45

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

Update vault/data_source_kv_secret_v2.go

ac8bb10

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

Update vault/resource_kv_secret_v2_test.go

ecc13e4

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

Update vault/resource_kv_secret_backend_v2_test.go

e1039be

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

Update vault/resource_kv_secret.go

794a139

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>

add constants for depth and data_json

ce4f799

add error messaging and update test names

e1f1bfa

Merge branch 'VAULT-1336/support-kv-list' of github.com:hashicorp/ter…

48f131f

…raform-provider-vault into VAULT-1336/support-kv-list

update subkeys test name

106ef58

convert computed data for datasource to TypeString instead of map

1fe0704

vinay-gopalan requested a review from benashz June 14, 2022 18:01

resolve merge conflicts

01bb2b1

benashz approved these changes Jun 14, 2022

View reviewed changes

vinay-gopalan added 2 commits June 14, 2022 11:54

remove unnecessary docs

242b229

add second step with updated path

2f503a8

vinay-gopalan merged commit 1593e86 into main Jun 14, 2022

vinay-gopalan deleted the VAULT-1336/support-kv-list branch June 14, 2022 20:09

benashz mentioned this pull request Jun 14, 2022

Feature request | Support vault list #57

Closed

vinay-gopalan added this to the 3.7.0 milestone Jun 15, 2022

This was referenced Jul 22, 2022

Add ability to configure for the kv-v2 mounts #1311

Closed

Feature Request: Add ability to configure for the kv-v2 mounts #1310

Closed

marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022

Add support for KV Secret Engine resources to move away from `vault_g…

33152ca

…eneric_secret` (hashicorp#1457)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for KV Secret Engine resources to move away from `vault_generic_secret` #1457

Add support for KV Secret Engine resources to move away from `vault_generic_secret` #1457

vinay-gopalan commented May 13, 2022 •

edited

Loading

benashz left a comment

benashz May 20, 2022

benashz left a comment

benashz left a comment

Add support for KV Secret Engine resources to move away from vault_generic_secret #1457

Add support for KV Secret Engine resources to move away from vault_generic_secret #1457

Conversation

vinay-gopalan commented May 13, 2022 • edited Loading

benashz left a comment

Choose a reason for hiding this comment

benashz May 20, 2022

Choose a reason for hiding this comment

benashz left a comment

Choose a reason for hiding this comment

benashz left a comment

Choose a reason for hiding this comment

Add support for KV Secret Engine resources to move away from `vault_generic_secret` #1457

Add support for KV Secret Engine resources to move away from `vault_generic_secret` #1457

vinay-gopalan commented May 13, 2022 •

edited

Loading