Support creating Azure secret backend role by specifying the role_id #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ added validation so only role_id or role_name is provided but not both + added acceptance test * converted from the deprecated schema callbacks to their version with Context & Diagnostics * various small formatting, warnings and standardization fixes
vinay-gopalan
approved these changes
Aug 12, 2022
| err := azureSecretBackendRoleUpdateFields(d, data) | ||
| if err != nil { | ||
| return err | ||
| diags := azureSecretBackendRoleUpdateFields(ctx, d, data) |
There was a problem hiding this comment.
looks like you're only returning diags if there is an error; else it is nil, in that case we have a style precedent of something like
if diags := azureSecretBackendRoleUpdateFields(ctx, d, data); diags != nil {
return diags
}
| @@ -47,6 +48,10 @@ func TestAzureSecretBackendRole(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet("vault_azure_secret_backend_role.test_azure_groups", "azure_groups.0.object_id"), | |||
| ), | |||
| }, | |||
| { | |||
| Config: testAzureSecretBackendRoleConfigError(subscriptionID, tenantID, clientID, clientSecret, path, role, resourceGroup), | |||
| Read: ReadWrapper(azureSecretBackendRoleRead), | ||
| Update: azureSecretBackendRoleCreate, | ||
| Delete: azureSecretBackendRoleDelete, | ||
| CreateContext: azureSecretBackendRoleCreate, |
There was a problem hiding this comment.
Thanks for updating these!
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
…ashicorp#1573) * + support creating Azure secret backend role by specifying the role_id + added validation so only role_id or role_name is provided but not both + added acceptance test * converted from the deprecated schema callbacks to their version with Context & Diagnostics * various small formatting, warnings and standardization fixes * * normalize style of diags.err hangling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #715
Release note for CHANGELOG:
Output from acceptance testing: