Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Mount Migration support to all secrets/auth backends #1594

Merged
merged 23 commits into from
Sep 13, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Sep 2, 2022

Adds mount migration support to all secrets/auth backends.

This PR removes the previously added semver package and instead moves those functions to meta.go instead. The ProviderMeta object now stores the Vault Version after making a call to the client.Sys().SealStatus() endpoint.

For testing, the best way I found to confirm that Mount Migration for secrets/auth mounts had successfully completed was by running a Remount test and then viewing the Vault logs to confirm that a Migration ID was dispatched, and the mount was moved accordingly:

2022-09-08T10:13:34.835-0700 [INFO]  core: successful mount: namespace="" path=tf-test-terraform-cloud-5084382457978848863/ type=terraform

2022-09-08T10:13:36.012-0700 [INFO]  core.mounts.migration: Starting to update the mount table and revoke leases: from_path=tf-test-terraform-cloud-5084382457978848863 migration_id=21d4beff-97c0-afac-974c-b18daf982bfd namespace="" to_path=tf-test-terraform-cloud-updated-8145651656808162423

2022-09-08T10:13:36.012-0700 [INFO]  core.mounts.migration: Removing the source mount from filtered paths on secondaries: from_path=tf-test-terraform-cloud-5084382457978848863 migration_id=21d4beff-97c0-afac-974c-b18daf982bfd namespace="" to_path=tf-test-terraform-cloud-updated-8145651656808162423

2022-09-08T10:13:36.012-0700 [INFO]  core.mounts.migration: Updating quotas associated with the source mount: from_path=tf-test-terraform-cloud-5084382457978848863 migration_id=21d4beff-97c0-afac-974c-b18daf982bfd namespace="" to_path=tf-test-terraform-cloud-updated-8145651656808162423

2022-09-08T10:13:36.012-0700 [INFO]  core.mounts.migration: Completed mount move operations: from_path=tf-test-terraform-cloud-5084382457978848863 migration_id=21d4beff-97c0-afac-974c-b18daf982bfd namespace="" to_path=tf-test-terraform-cloud-updated-8145651656808162423

2022-09-08T10:13:38.301-0700 [INFO]  core: successfully unmounted: path=tf-test-terraform-cloud-updated-8145651656808162423/ namespace=""

internal/provider/meta.go Outdated Show resolved Hide resolved
internal/provider/meta.go Outdated Show resolved Hide resolved
internal/provider/meta.go Outdated Show resolved Hide resolved
internal/provider/meta.go Outdated Show resolved Hide resolved
vault/resource_ad_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_consul_secret_backend.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan marked this pull request as ready for review September 6, 2022 18:03
@vinay-gopalan vinay-gopalan added this to the 3.9.0 milestone Sep 6, 2022
internal/provider/meta.go Show resolved Hide resolved
internal/provider/meta.go Show resolved Hide resolved
internal/provider/meta.go Outdated Show resolved Hide resolved
internal/provider/meta.go Show resolved Hide resolved
internal/provider/meta.go Outdated Show resolved Hide resolved
vault/resource_ad_secret_backend_test.go Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_consul_secret_backend.go Show resolved Hide resolved
vault/resource_consul_secret_backend_role.go Outdated Show resolved Hide resolved
vault/resource_ad_secret_backend_test.go Show resolved Hide resolved
vault/provider.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
internal/consts/consts.go Outdated Show resolved Hide resolved
vault/provider.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_kubernetes_secret_backend.go Outdated Show resolved Hide resolved
vault/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits/suggestions to address; then 👍

vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_consul_secret_backend_test.go Outdated Show resolved Hide resolved
vault/resource_consul_secret_backend_test.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan merged commit f0c1312 into main Sep 13, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-7442/secrets-auth-mount-mig branch September 13, 2022 00:24
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants