Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first-class GCP login support #1607

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Add first-class GCP login support #1607

merged 3 commits into from
Sep 19, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Sep 16, 2022

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

vinay-gopalan
vinay-gopalan reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Couple of comments/questions

internal/provider/auth_gcp.go Show resolved Hide resolved
website/docs/index.html.markdown Outdated Show resolved Hide resolved
website/docs/index.html.markdown Show resolved Hide resolved
@benashz @vinay-gopalan
Update website/docs/index.html.markdown
868cd8c 
Co-authored-by: vinay-gopalan <86625824+vinay-gopalan@users.noreply.github.com>
@benashz benashz changed the title Add first-class GCP certificates login support Add first-class GCP login support Sep 19, 2022
vinay-gopalan
vinay-gopalan approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benashz benashz merged commit 815e50b into main Sep 19, 2022
@benashz benashz deleted the VAULT-6155/gcp-login-support branch September 19, 2022 19:14
This was referenced Sep 26, 2022
Closed
Closed
@benashz benashz added this to the 3.9.0 milestone Oct 5, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz @vinay-gopalan
Add first-class GCP login support (hashicorp#1607)
f6e160b 
Co-authored-by: vinay-gopalan <86625824+vinay-gopalan@users.noreply.github.com>
@itspngu itspngu mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benashz @vinay-gopalan