Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous persistent diff in the vault_token resource. #1622

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 5, 2022

The vault_token resource would produce a persistent diff for the renewable and policies fields. This PR ensures a valid diff is produced upon plan.

Other fixes:

  • factor out more constants
  • clean up extraneous bits in consts.go

The vault_token resource would produce a persistent diff for the
renewable and policies fields.

- factor out more constants
- clean up extraneous bits in consts.go
@github-actions github-actions bot added the size/L label Oct 5, 2022
@benashz benashz added this to the 3.9.0 milestone Oct 5, 2022
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz merged commit 67116ca into main Oct 5, 2022
@benashz benashz deleted the VAULT-8097/fix-vault-token-renewable branch October 5, 2022 19:16
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
…#1622)

The vault_token resource would produce a persistent diff for the
renewable and policies fields.

- factor out more constants
- clean up extraneous bits in consts.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants