Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that namespaced github auth mounts are destroyed #1637

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 13, 2022

  • add regression test for namespaced mount
  • normalize related tests

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1635

Release note for CHANGELOG:


Output from acceptance testing:

 $ make testacc-ent SKIP_VAULT_NEXT_TESTS=1 TESTARGS='-v -test.run TestAccGithubAuthBackend -test.count=1'
make testacc TF_ACC_ENTERPRISE=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -test.run TestAccGithubAuthBackend -test.count=1 -timeout 30m ./...

2022/10/13 13:08:35 [INFO] Using Vault token with the following policies: root
=== RUN   TestAccGithubAuthBackend_basic
--- PASS: TestAccGithubAuthBackend_basic (1.83s)
=== RUN   TestAccGithubAuthBackend_ns
--- PASS: TestAccGithubAuthBackend_ns (1.84s)
=== RUN   TestAccGithubAuthBackend_tuning
--- PASS: TestAccGithubAuthBackend_tuning (1.66s)
=== RUN   TestAccGithubAuthBackend_description
--- PASS: TestAccGithubAuthBackend_description (1.68s)
=== RUN   TestAccGithubAuthBackend_importTuning
--- PASS: TestAccGithubAuthBackend_importTuning (1.23s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     8.837s

- add regression test for namespaced mount
- normalize related tests
@benashz benashz added this to the 3.10.0 milestone Oct 13, 2022
@benashz benashz changed the title Ensure that the namespaced github auth mount is destroyed Ensure that namespaced github auth mount is destroyed Oct 13, 2022
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benashz benashz merged commit 3119556 into main Oct 13, 2022
@benashz benashz changed the title Ensure that namespaced github auth mount is destroyed Ensure that namespaced github auth mounts are destroyed Oct 13, 2022
@benashz benashz deleted the VAULT-9338/ensure-namespaced-mounts-are-destroyed branch October 13, 2022 17:55
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
- add regression test for namespaced mount
- normalize related tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_github_auth_backend does *not* remove auth backend in vault when destroying
2 participants