Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enterprise check for new Raft Autopilot parameter #1721

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Jan 9, 2023

In v3.12.0 we added a new parameter to the Raft Autopilot resource disable_upgrade_migration. There was a bug introduced due to the field having a default value of false written to Vault, and since this is an enterprise field this was breaking the TF config s for non-enterprise users. The improvements made in this PR fix the bug and also add some utils to the provider package to check for enterprise servers.

Fixes #1718

Output from acceptance testing:

=== RUN   TestAccRaftAutopilotConfig_basic
--- PASS: TestAccRaftAutopilotConfig_basic (2.59s)
PASS

=== RUN   TestIsEnterpriseSupported
=== RUN   TestIsEnterpriseSupported/not-enterprise
=== RUN   TestIsEnterpriseSupported/enterprise-hsm
=== RUN   TestIsEnterpriseSupported/enterprise
--- PASS: TestIsEnterpriseSupported (0.00s)
    --- PASS: TestIsEnterpriseSupported/not-enterprise (0.00s)
    --- PASS: TestIsEnterpriseSupported/enterprise-hsm (0.00s)
    --- PASS: TestIsEnterpriseSupported/enterprise (0.00s)
PASS

@vinay-gopalan vinay-gopalan added this to the 3.12.1 milestone Jan 9, 2023
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinay-gopalan vinay-gopalan merged commit b5f2b80 into main Jan 18, 2023
@vinay-gopalan vinay-gopalan deleted the fix/raft-autopilot-enterprise branch January 18, 2023 17:00
@vinay-gopalan vinay-gopalan modified the milestones: 3.12.1, 3.13.0 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource vault_raft_autopilot doesn't work anymore on non enterprise customers
2 participants