Fix construction of metadata path in KV V2 resource #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
Jan 10, 2023
fairclothjm
approved these changes
Jan 12, 2023
fairclothjm
reviewed
Feb 15, 2023
fairclothjm
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3.12.0 we enabled support for adding metadata to KV V2 secrets. This introduced a regression due to incorrect construction of the metadata path while reading metadata from Vault. This PR fixes the construction of the metadata path, and also ensures that the fields
nameandmountare now being set on imports. The PR also adds an updated test to cover the use-cases that would reproduce this bug.Fixes #1719