Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws auth backend config identity #1724

Merged
merged 7 commits into from
Jan 27, 2023

Conversation

fairclothjm
Copy link
Contributor

This change introduces the aws_auth_backend_config_identity resource so that users can configure the way the AWS auth backend interacts with the Identity store. This is adapted from the community PR #1248

Release note for CHANGELOG:

`resource/aws_auth_backend_config_identity`: Configure how Vault interacts with the Identity store for AWS authentication

Output from acceptance testing:

$ TESTARGS="--run TestAccAwsAuthBackendConfigIdentity" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test --run TestAccAwsAuthBackendConfigIdentity -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	1.501s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	2.873s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	1.318s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	2.225s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	3.068s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	1.360s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	4.715s

rbhitchcock and others added 3 commits January 10, 2023 09:05
This change introduces the `aws_auth_backend_config_identity` resource
so that users can configure the way the AWS auth backend interacts with
the Identity store.

Resolves #733
@vinay-gopalan vinay-gopalan added this to the 3.13.0 milestone Jan 11, 2023
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had a couple comments about using constants and adding the namespace field to the docs, but otherwise looks good to go; thanks for adding this! 😄

@fairclothjm fairclothjm merged commit 92c33fc into main Jan 27, 2023
@fairclothjm fairclothjm deleted the add-aws_auth_backend_config_identity branch January 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants