Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespaces data source #2212

Merged
merged 10 commits into from Mar 27, 2024
Merged

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Mar 26, 2024

Description

Piggy backs on the work from #1769 to add a data source to fetch the list of namespaces

Closes #1769
Closes #995

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

@vinay-gopalan
Copy link
Contributor

vinay-gopalan commented Mar 26, 2024

FYI, some tests are failing in branches against Vault CE (unrelated to this PR) since they need to be Enterprise only. They should be fixed in main once the Secrets Sync PR (#2202) goes in. Here is the commit that fixes the tests. Pulling in main after the above PR is merged should fix the CI pipeline!

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had a couple of questions, but should be good to go otherwise

vault/data_source_namespaces.go Show resolved Hide resolved
vault/data_source_namespaces.go Outdated Show resolved Hide resolved
@fairclothjm fairclothjm merged commit 7b81a2a into main Mar 27, 2024
2 checks passed
@fairclothjm fairclothjm deleted the fairclothjm/namespaces_data_source branch March 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to check if Vault namespace already exist - getting "* namespace "mynamespace/" already exists"
3 participants