-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for namespaces #262
Conversation
Any ideas when this pull request will be merged? |
Thanks! |
Should this work or is there still a missing piece? I built from Fails with Terraform
Works with CLI
Saw the merge and thought perhaps I could use it as-is. Perhaps I'm being presumptuous. |
I faced the similar situation with this error. Fails with Terraform$ ls /root/.terraform.d/plugins/
terraform-provider-vault_v1.4.2-custom provider "vault" {
address = "https://vault.dev.our_company.com:8200"
token = "s.xxx"
namespace = "microservices/our_service_A"
}
Works with CLI$ vault read secret/cert_asterisk_our_company_com_2018
Key Value
--- -----
refresh_interval 768h
crt xxx
pem xxx |
I was able to reproduce the issue - not sure how it slipped during initial testing. |
Fix for namespaces (#262)
* upstream/master: (41 commits) go fmt fix bad merge add binary to .gitignore go fmt go fmt go fmt Added acceptance tests Fix for namespaces (hashicorp#262) Added Azure auth support for backend config and role. go fmt Added support for EGP and RGP (sentinel) Refactor tests Update docs Rename file Add sensitive flag to private key and bundle attributes Add vault_pki_secret_backend_ca_config resource Enforce dependencies to pass tests Reformat Add tests Fix resources attributes ... # Conflicts: # vault/provider.go # vault/resource_identity_entity.go # vault/resource_identity_entity_alias.go # vault/resource_identity_entity_alias_test.go # vault/resource_identity_entity_test.go
Works like a charm. Thanks so much for implementing this. Huge win to me. Cheers. |
Nice! Thank you! I'll check it later. BTW when will these change be release? |
Implementation of hashicorp#262 was buggy. Vault token used by Terraform should be created without namespace - otherwise the token will have wrong set of policies assigned
Fix for namespaces (hashicorp#262)
* upstream/master: (41 commits) go fmt fix bad merge add binary to .gitignore go fmt go fmt go fmt Added acceptance tests Fix for namespaces (hashicorp#262) Added Azure auth support for backend config and role. go fmt Added support for EGP and RGP (sentinel) Refactor tests Update docs Rename file Add sensitive flag to private key and bundle attributes Add vault_pki_secret_backend_ca_config resource Enforce dependencies to pass tests Reformat Add tests Fix resources attributes ... # Conflicts: # vault/provider.go # vault/resource_identity_entity.go # vault/resource_identity_entity_alias.go # vault/resource_identity_entity_alias_test.go # vault/resource_identity_entity_test.go
PR for #175