Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite vault_namespace path with response value. #396

Merged
merged 3 commits into from
May 7, 2019
Merged

Don't overwrite vault_namespace path with response value. #396

merged 3 commits into from
May 7, 2019

Commits on May 2, 2019

  1. Don't overwrite path with response value. 

    Overwriting the path with the one returned by Vault causes an invalid namespace to be set when using nested namespaces.
ex: namespace-b which is inside namespace-a will have the path overwritten with namespace-a/namespace-b/ when the correct value is namespace-b/
    @williams-brian
    williams-brian committed May 2, 2019
    Configuration menu
    Copy the full SHA
    667e9be View commit details
    Browse the repository at this point in the history

  2. Add test case for nested namespaces

    @williams-brian
    williams-brian committed May 2, 2019
    Configuration menu
    Copy the full SHA
    a517d88 View commit details
    Browse the repository at this point in the history

  3. Use instanceState instead of resourceState.Primary

    @williams-brian
    williams-brian committed May 2, 2019
    Configuration menu
    Copy the full SHA
    4a25048 View commit details
    Browse the repository at this point in the history