Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vault_azure_secret_backend_role support for azure_groups #891

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Add vault_azure_secret_backend_role support for azure_groups #891

merged 2 commits into from
Dec 14, 2020

Conversation

mdgreenfield
Copy link
Contributor

@mdgreenfield mdgreenfield commented Nov 2, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #712

Release note for CHANGELOG:

`resource/vault_azure_secret_backend_role`: Added support for `azure_groups` (#891)

Output from acceptance testing:

$ TESTARGS="--run TestAzureSecretBackendRole" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v --run TestAzureSecretBackendRole -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/generate    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/codegen (cached) [no tests to run]
?       github.com/terraform-providers/terraform-provider-vault/generated       [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/datasources/transform/decode  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/datasources/transform/encode  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/resources/transform/alphabet  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/resources/transform/role      (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/resources/transform/template  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/generated/resources/transform/transformation       (cached) [no tests to run]
?       github.com/terraform-providers/terraform-provider-vault/schema  [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    (cached) [no tests to run]
=== RUN   TestAzureSecretBackendRole
--- PASS: TestAzureSecretBackendRole (0.62s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   (cached)

@jasonodonnell jasonodonnell added this to the 2.16.1 milestone Nov 19, 2020
@dwizzle204 dwizzle204 mentioned this pull request Nov 25, 2020
Closed
@jasonodonnell
Copy link
Collaborator

Thanks for the contribution, @mdgreenfield! Minor feedback but looks alright to me.

jasonodonnell
jasonodonnell approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit 47a19d6 into hashicorp:master Dec 14, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@mdgreenfield
Add vault_azure_secret_backend_role support for azure_groups (hashico…
f3d1428 
…rp#891)

* Add vault_azure_secret_backend_role support for azure_groups

Fixes hashicorp#712

* Handle json.Marshal error for azure_secret_backend_role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

vault_azure_secret_backend_role to support azure_groups
2 participants
@mdgreenfield @jasonodonnell