Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update 'time to leave' to 'time to live' #896

Merged
merged 1 commit into from Nov 6, 2020

Conversation

kjgorman
Copy link
Contributor

@kjgorman kjgorman commented Nov 5, 2020

Small typo in these descriptions - 'ttl' should be 'time to live' (as documented
for example, here: https://www.vaultproject.io/api-docs/secret/pki#ttl).

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes N/A

Release note for CHANGELOG:

NONE

Output from acceptance testing:

(I didn't run these as it's a doc only change... let me know if you'd still like me to do this.)

Small typo in these descriptions - 'ttl' should be 'time to live' (as documented
for example, here: https://www.vaultproject.io/api-docs/secret/pki#ttl).
@ghost ghost added the size/XS label Nov 5, 2020
@kjgorman
Copy link
Contributor Author

kjgorman commented Nov 5, 2020

There's a test failure, which I assume is unrelated:

--- FAIL: TestAccIdentityGroupMemberEntityIdsNonExclusive (0.34s)
    testing.go:640: Step 2 error: Check failed: unexpected member entity id a3bb0ae2-dc1e-4dab-4a85-e5968e9005b8 in group b037ef36-92f6-8296-7c29-e5e0b587193

Copy link
Member

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@catsby catsby merged commit 6c909cc into hashicorp:master Nov 6, 2020
@kjgorman kjgorman deleted the docs-pki-secret-backend-ttl-typo branch December 11, 2020 10:59
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Small typo in these descriptions - 'ttl' should be 'time to live' (as documented
for example, here: https://www.vaultproject.io/api-docs/secret/pki#ttl).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants