Mr miles ca cert #910
Merged
Mr miles ca cert #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional options to configure to match the cli/api for the consul backend. Important for TLS configuration.
ghost
added
|
|
|
The check failure is because the PR description was longer than jira's max issue size. It is not related to the PR code. |
tvoran
reviewed
Jan 13, 2021
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
tvoran
reviewed
Jan 14, 2021
There was a problem hiding this comment.
The other thing I'd suggest is to test those new parameters a bit in TestConsulSecretBackend(). Even though these parameters don't come back from vault, the terraform state can be checked in tests.
Pull from master
|
Good idea, I added some tests for the extra properties |
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
* Add support for ca_cert, client_cert, client_key Additional options to configure to match the cli/api for the consul backend. Important for TLS configuration. * Update resource_consul_secret_backend.go * Missing quote * Adding commas * Set optional and default value * Update docs * Change detection * optional param * Don't compare ca_cert as vault does not return it Co-authored-by: Theron Voran <tvoran@users.noreply.github.com> * Adding state tests for additional fields * Add comma * remove blank attributes * Reinstate blank properties * Back in business - check attribute does note exist Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #901
Release note for CHANGELOG:
Output from acceptance testing:
(running on windows [shudder] so here's the circleci output)