Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: JWT/OIDC provider_config for gsuite #953

Closed
wants to merge 1 commit into from

Conversation

Kostavro
Copy link

@Kostavro Kostavro commented Jan 25, 2021

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #828

Release note for CHANGELOG:

Enable all variables in provider_config block of OIDC auth as per documentation concerning gsuite. 
This should add on top of @Gaardsholt implementation at https://github.com/hashicorp/terraform-provider-vault/pull/943

Output from acceptance testing:

   鈺扳暭 蠠 make test                                                                                                                                                   
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
echo $(go list ./... |grep -v 'vendor') | \
        xargs -t -n4 go test  -timeout=30s -parallel=4
go test '-timeout=30s' '-parallel=4' github.com/hashicorp/terraform-provider-vault github.com/hashicorp/terraform-provider-vault/cmd/coverage github.com/hashicorp/terraform-provider-vault/cmd/generate github.com/hashicorp/terraform-provider-vault/codegen 
?       github.com/hashicorp/terraform-provider-vault   [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/coverage      [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/generate      [no test files]
ok      github.com/hashicorp/terraform-provider-vault/codegen   (cached)
go test '-timeout=30s' '-parallel=4' github.com/hashicorp/terraform-provider-vault/generated github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet 
?       github.com/hashicorp/terraform-provider-vault/generated [no test files]
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode    (cached)
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode    (cached)
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet    (cached)
go test '-timeout=30s' '-parallel=4' github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation github.com/hashicorp/terraform-provider-vault/schema 
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role        (cached)
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template    (cached)
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation      (cached)
?       github.com/hashicorp/terraform-provider-vault/schema    [no test files]
go test '-timeout=30s' '-parallel=4' github.com/hashicorp/terraform-provider-vault/util github.com/hashicorp/terraform-provider-vault/vault 
ok      github.com/hashicorp/terraform-provider-vault/util      (cached)
ok      github.com/hashicorp/terraform-provider-vault/vault     (cached)

...

@ghost ghost added the size/S label Jan 25, 2021
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@Kostavro Kostavro mentioned this pull request Jan 25, 2021
@Kostavro Kostavro changed the title JWT/OIDC provider_config for gsuite WIP: JWT/OIDC provider_config for gsuite Jan 26, 2021
@jasonodonnell
Copy link
Collaborator

Fix proposed here: #960

@Kostavro Kostavro closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: resource_jwt_auth_backend - add provider_config
3 participants