Allow vApp userConfigurable=false properties to be configured

[adarobin]

Description

This adds a new option under ovf_deploy named enable_hidden_properties. This allows vApp properties that are marked with userConfigurable=false to be set. The most obvious use case for this functionality is directly deploying the vCenter Server Appliance OVA without using the installer. The setting defaults to false which preserves the existing behavior.

The name is based off the name for an advanced option to ovftool.

$ ovftool --help debug | grep -A3 enableHidden 
  --X:enableHiddenProperties          : Enable source properties that are 
                                        marked as ovf:userConfigurable=false, 
                                        OVF Tool will set the value to true. 
                                        The default is false

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

• Don't touch vapp properties (ovf) where ovf:userConfigurable="false" #394
• https://www.virtuallyghetto.com/2016/10/how-to-deploy-the-vcenter-server-appliance-vcsa-6-5-running-on-vmware-fusion-workstation.html

[bill-rich]

Hi @adarobin! Have you been successful using the changes to apply templates with userConfigurable=false? In the past when I've tried the same, it results in vCenter returning an error. I think ovftool may be altering the OVF on the fly when deploying to make this work.

[adarobin]

Hi @bill-rich I have been using this to deploy vCenter Server Appliance consistently without using the installer in my homelab.

I have been thinking it might make more sense to move the new option under vApp instead of ovf_deploy.

[hashicorp-cla]

All committers have signed the CLA.

[tvishwanatharkin]

Any update on when this feature will be available?

[koikonom]

LGTM

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.