Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix addressing issue-1809. #1996

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Bugfix addressing issue-1809. #1996

merged 1 commit into from
Aug 17, 2023

Conversation

nklinkachevAtVMware
Copy link
Contributor

@nklinkachevAtVMware nklinkachevAtVMware commented Aug 17, 2023

Description

Bugfix for #1809
Split the storage controller change and the harddisk edit operations into separate API calls. The previous behaviour was to generate 2 edit operations for the harddisk object which leadto an undefined API behavior.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

no regresions

Release Note

Release note for CHANGELOG:

`r/virtual_machine`: Fix "Invalid operation for device '0'" when reconfiguring a VM ([#1809](https://github.com/hashicorp/terraform-provider-vsphere/issues/1809))

References

Split the storage controller change and the harddisk edit operations into separate API calls to vsphere.
The previosu behaviour was to generate 2 edit operations for the harddisk object which leads to an undefined API behavior.
@nklinkachevAtVMware nklinkachevAtVMware requested a review from a team as a code owner August 17, 2023 19:32
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added provider Type: Provider size/m Relative Sizing: Medium labels Aug 17, 2023
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appilon appilon merged commit cdf9725 into main Aug 17, 2023
5 of 6 checks passed
@appilon appilon deleted the issue-1809 branch August 17, 2023 20:17
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Type: Provider size/m Relative Sizing: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants