Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update r/vsphere_nic docs #2017

Merged
merged 1 commit into from
Sep 11, 2023
Merged

docs: update r/vsphere_nic docs #2017

merged 1 commit into from
Sep 11, 2023

Conversation

tenthirtyam
Copy link
Collaborator

Description

  • Updated the example to show services instead of enabled_services.
  • Updated minor markdown errors.
  • Updated CHANGELOG.md.

Release Note

IMPROVEMENTS:

* `vsphere_nic`: Documentation updates to resource.

References

Closes #1976

@tenthirtyam tenthirtyam added the documentation Type: Documentation label Sep 10, 2023
@tenthirtyam tenthirtyam added this to the v2.5.0 milestone Sep 10, 2023
@tenthirtyam tenthirtyam self-assigned this Sep 10, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 10, 2023 22:28
@github-actions github-actions bot added provider Type: Provider size/m Relative Sizing: Medium labels Sep 10, 2023
@tenthirtyam tenthirtyam changed the title docs: update r/vsphere_nic docs. docs: update r/vsphere_nic docs Sep 10, 2023
@tenthirtyam
docs: update r/vsphere_nic docs
4d3112b 
- Updated the example to show `services` instead of `enabled_services`.
- Updated minor markdown errors.
- Updated `CHANGELOG.md`.

Ref: #1976

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam merged commit 76c0a2f into main Sep 11, 2023
4 checks passed
@tenthirtyam tenthirtyam deleted the docs/update-vsphere-nic branch September 11, 2023 17:28
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This functionality has been released in v2.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@rismoney
Copy link

rismoney commented Oct 9, 2023 •
edited

Slightly tangential to this documentation, that I just ran into
If netstack is vmotion, services cannot be set, since I think these 2 settings are mutually exclusive, not purely optional. Also I think it's a bug that probably needs to be filed, but I believe if netstack is set to vmotion, there will be a subsequent diff problem where the provider will state that the 'service' value will be removed , since netstack adds that service as an implicit service, creating a catch-22 [netstack set, and service being unsettable]. I worked around this by ignore changes on service, but I thought it worthwhile to mention.

@rismoney rismoney mentioned this pull request Oct 11, 2023
Open
4 tasks
@dtmorris1 dtmorris1 mentioned this pull request Oct 23, 2023
Open
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
documentation Type: Documentation provider Type: Provider size/m Relative Sizing: Medium
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

error in r/vsphere_vnic docs
3 participants
@tenthirtyam @rismoney @iBrandyJackson